chore: resolve eslint issues

Screenly · Dec 4, 2024 · 4e749ba · 4e749ba
1 parent d894141
commit 4e749ba
Show file tree

Hide file tree

Showing 7 changed files with 36 additions and 25 deletions.
diff --git a/eslint.config.mjs b/eslint.config.mjs
@@ -1,9 +1,9 @@
-import jasmine from "eslint-plugin-jasmine";
-import globals from "globals";
-import path from "node:path";
-import { fileURLToPath } from "node:url";
-import js from "@eslint/js";
-import { FlatCompat } from "@eslint/eslintrc";
+import jasmine from 'eslint-plugin-jasmine';
+import globals from 'globals';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import js from '@eslint/js';
+import { FlatCompat } from '@eslint/eslintrc';
 
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = path.dirname(__filename);
@@ -15,25 +15,26 @@ const compat = new FlatCompat({
 
 export default [
   ...compat.extends(
-    "eslint:recommended",
-    "plugin:react/recommended",
-    "plugin:jasmine/recommended"
+    'eslint:recommended',
+    'plugin:react/recommended',
+    'plugin:jasmine/recommended'
   ),
   {
     ignores: [
-      "src/lib/vendor/",
-      "node_modules/",
-      "dist/",
-    ]
+      'src/lib/vendor/',
+      'node_modules/',
+      'dist/',
+    ],
   },
   {
+    files: ['**/*.{js,jsx,mjs}'],
     plugins: {
       jasmine,
     },
 
     settings: {
       react: {
-        version: "detect",
+        version: 'detect',
       },
     },
 
@@ -42,12 +43,12 @@ export default [
         ...globals.browser,
         ...globals.jasmine,
         ...globals.node,
-        Atomics: "readonly",
-        SharedArrayBuffer: "readonly",
+        Atomics: 'readonly',
+        SharedArrayBuffer: 'readonly',
       },
 
-      ecmaVersion: "latest",
-      sourceType: "module",
+      ecmaVersion: 'latest',
+      sourceType: 'module',
 
       parserOptions: {
         ecmaFeatures: {
@@ -56,6 +57,8 @@ export default [
       },
     },
 
-    rules: {},
+    rules: {
+      'react/prop-types': 'off',
+    },
   }
 ];
diff --git a/src/assets/js/components/options/authenticated-options.jsx b/src/assets/js/components/options/authenticated-options.jsx
@@ -1,3 +1,5 @@
+/* global browser */
+
 import React from 'react';
 import { useDispatch } from 'react-redux';
 import { useState } from 'react';
@@ -14,7 +16,7 @@ export const AuthenticatedOptionsView = () => {
 
     try {
       await browser.storage.sync.clear();
-    } catch (error) {
+    } catch {
       return;
     } finally {
       setIsLoading(false);

diff --git a/src/assets/js/components/options/sign-in.jsx b/src/assets/js/components/options/sign-in.jsx
@@ -1,3 +1,5 @@
+/* global browser */
+
 import React from 'react';
 import { useState } from 'react';
 import { useDispatch } from 'react-redux';
@@ -43,7 +45,7 @@ export const SignInForm = () => {
 
       setShowSignInFormError(false);
       dispatch(signIn());
-    } catch (error) {
+    } catch {
       setShowSignInFormError(true);
     } finally {
       setIsLoading(false);

diff --git a/src/assets/js/components/options/token-help-text.jsx b/src/assets/js/components/options/token-help-text.jsx
@@ -8,6 +8,7 @@ export const TokenHelpText = () => {
         <a
           href="https://support.screenly.io/hc/en-us/articles/35897560148371-How-to-Generate-a-Screenly-API-Token"
           target="_blank"
+          rel="noreferrer"
         >this page</a>&nbsp;for details.
       </p>
     </div>

diff --git a/src/assets/js/components/popup/proposal.jsx b/src/assets/js/components/popup/proposal.jsx
@@ -1,3 +1,5 @@
+/* global browser */
+
 import React from 'react';
 import { useEffect, useState } from 'react';
 import { useDispatch } from 'react-redux';
@@ -20,7 +22,7 @@ import {
   setShowSuccess,
 } from '@/features/popup/popupSlice';
 
-export const Proposal = (props) => {
+export const Proposal = () => {
   const dispatch = useDispatch();
   const [isLoading, setIsLoading] = useState(false);
   const [assetTitle, setAssetTitle] = useState('');
@@ -161,7 +163,7 @@ export const Proposal = (props) => {
       }
 
       await proposeToAddToScreenly(user, pageUrl, pageTitle, cookieJar);
-    } catch (error) {
+    } catch {
       window.close();
     }
   };

diff --git a/src/assets/js/components/popup/sign-in.jsx b/src/assets/js/components/popup/sign-in.jsx
@@ -1,7 +1,9 @@
+/* global browser */
+
 import React from 'react';
 
 export const SignInCallToAction = () => {
-  const handleSignIn = (event) => {
+  const handleSignIn = () => {
     browser.runtime.openOptionsPage();
   };
 

diff --git a/src/assets/js/components/popup/success.jsx b/src/assets/js/components/popup/success.jsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import { useSelector } from 'react-redux';
 
 export const Success = ({ assetDashboardLink }) => {
   const openAssetDashboard = () => {