Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix run_tests.sh; refactor Bash scripts #89

Merged
merged 1 commit into from
Jan 24, 2025
Merged

chore: fix run_tests.sh; refactor Bash scripts #89

merged 1 commit into from
Jan 24, 2025

Conversation

nicomiguelino
Copy link
Collaborator

Issues Fixed

  • Fixes the issue where running ./bin/run_tests.sh yields an error.

Description

  • bin/run_tests.sh should be updated so that a file called manifest.json can be generated.

Checklist

  • I have performed a self-review of my own code.
  • New and existing unit tests pass locally and on CI with my changes.
  • I have tested my changes on Google Chrome.
  • I have tested my changes on Mozilla Firefox.
  • I added a documentation for the changes I have made (when necessary).

@nicomiguelino nicomiguelino merged commit c93f6ec into master Jan 24, 2025
4 checks passed
@nicomiguelino nicomiguelino deleted the fix-run-test-script branch January 24, 2025 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpetersson vpetersson vpetersson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nicomiguelino @vpetersson