Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mock feature flag docs #2109

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Add mock feature flag docs #2109

merged 1 commit into from
Feb 28, 2024

Conversation

AngelOnFira
Copy link
Contributor

This adds some better docs for why DatabaseConnection might not be clone. From a discussion on Discord: https://discord.com/channels/873880840487206962/1205866461935964182

@AngelOnFira
Copy link
Contributor Author

I'm not sure if this is the only doc fix that is needed, since many examples seem to include mock by default, meaning that people who copy them as templates will likely run into this problem.

tyt2y3
tyt2y3 approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@tyt2y3 tyt2y3 merged commit 88fafa5 into SeaQL:master Feb 28, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AngelOnFira @tyt2y3