Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect on_condition when batch loading relations #2471

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Respect on_condition when batch loading relations #2471

wants to merge 3 commits into from

Conversation

georgeboot
Copy link

Bug Fixes

  • When using batch loading (LoaderTrait), the on_condition of a relation was not applied.

tyt2y3
tyt2y3 reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This seems to be a valid fix, can you also add a test case, so we'd not break it in the future?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@georgeboot @tyt2y3