Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: handle when referential_constraints_subquery.table_name is null #125

Merged
merged 1 commit into from
Feb 24, 2024
Merged

fix: handle when referential_constraints_subquery.table_name is null #125

merged 1 commit into from
Feb 24, 2024

Conversation

omjadas
Copy link
Contributor

@omjadas omjadas commented Feb 22, 2024

PR Info

Bug Fixes

  • constraints weren't properly being queried when a database contained partitions, due to null handling

Breaking Changes

  • fixed a typo, changed query_table_constriants -> query_table_constraints

tyt2y3
tyt2y3 approved these changes Feb 24, 2024
View reviewed changes
Copy link
Member

@tyt2y3 tyt2y3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@tyt2y3 tyt2y3 merged commit f139abc into SeaQL:master Feb 24, 2024
27 checks passed
@github-actions GitHub Actions
Copy link

🎉 Released In 0.15.0-rc.3 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

28Smiles added a commit to 28Smiles/sea-schema that referenced this pull request Apr 21, 2024
@28Smiles
Revert "fix: handle when referential_constraints_subquery.table_name …
5781a7b 
…is null (SeaQL#125)"

This reverts commit f139abc.
28Smiles added a commit to 28Smiles/sea-schema that referenced this pull request Apr 21, 2024
@28Smiles
Revert "fix: handle when referential_constraints_subquery.table_name …
be8ffe2 
…is null (SeaQL#125)"

This reverts commit f139abc.
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 9, 2024

🎉 Released In 0.15.0 🎉

Thank you everyone for the contribution!
This feature is now available in the latest release. Now is a good time to upgrade!
Your participation is what makes us unique; your adoption is what drives us forward.
You can support SeaQL 🌊 by starring our repos, sharing our libraries and becoming a sponsor ⭐.

@KeXiangWang KeXiangWang mentioned this pull request Sep 8, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyt2y3 tyt2y3 tyt2y3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing primary_key attributes when generating from a DB with partitions
2 participants
@omjadas @tyt2y3