Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes in this pull-request.
Change the way we satisfy our compiler-dependency from being git
submodule based to being "Go there and compile it from source you
twat" based. And change what compiler we use.
Optimally our compiler-dependency would be satisified by a
package, but no-one has created one yet and I found it
disappointingly tricky to create one myself. I believe that it is
unnecessary to have a git submodule when we are not going to
contribute back to the compiler. But this can be debated, thus
the pull-request.
We change the compiler used from riscv-gcc to riscv-gnu-toolchain
because riscv-gcc is deprecated[1].
[1] riscvarchive/riscv-old-gcc#17 (comment)