Skip to content

Commit

Permalink
Tweaks for Hunt Cypress Tests
Browse files Browse the repository at this point in the history
Added Some IDs and Data-Aids I didn't mean to leave out. Useful for tests.

Refactored reactive calls that didn't come to light until Cypress tests were run.
  • Loading branch information
coreyogburn committed Sep 25, 2024
1 parent 8787262 commit 084f701
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
5 changes: 2 additions & 3 deletions html/index.html
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ <h4 v-if="loaded" :data-aid="'event_total_' + category">{{ i18n.eventTotal }} {{
<div v-if="isExpandedSection('hunt-graphs')">
<v-row v-if="!metricsEnabled" :data-aid="'timeline_' + category">
<v-col cols="12">
<line-chart :height="chartHeight" :data="timelineChartData" :options="timelineChartOptions"/>
<line-chart id="timelineChart" :height="chartHeight" :data="timelineChartData" :options="timelineChartOptions"/>
</v-col>
</v-row>
<v-row v-if="metricsEnabled">
Expand Down Expand Up @@ -734,7 +734,7 @@ <h4 v-if="loaded" :data-aid="'event_total_' + category">{{ i18n.eventTotal }} {{
<v-icon class="tiny-icon">fa-caret-left</v-icon>
</v-btn>
</span>
<span @click="toggleSort(header)">
<span :id="'col_label_' + header.value" :data-aid="'events_col_sort_' + category" @click="toggleSort(header)">
{{ header.title }}
</span>
<span class="table-header-actions" :data-aid="'events_move_right_' + category">
Expand Down Expand Up @@ -1061,7 +1061,6 @@ <h4 v-if="loaded" :data-aid="'event_total_' + category">{{ i18n.eventTotal }} {{
<v-card>
<v-card-title class="text-h5" v-text="i18n.actionAddToCase" />
<v-card-text data-aid="add_to_case_dialog_select">
{{ selectedMruCase }}
<v-select id="case-select" v-if="addToCaseDialogVisible" v-model="selectedMruCase" :items="mruCases" :label="i18n.mruCases"></v-select>
</v-card-text>
<v-card-actions>
Expand Down
2 changes: 1 addition & 1 deletion html/js/routes/jobs.js
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ routes.push({ path: '/jobs', name: 'jobs', component: {
this.jobs.splice(i, 1);
} else {
this.$root.populateUserDetails(job, "userId", "owner");
this.$set(this.jobs, i, job);
this.jobs[i] = job;
}
break;
}
Expand Down
2 changes: 1 addition & 1 deletion html/js/routes/users.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ routes.push({ path: '/users', name: 'users', component: {
updateUser(user) {
for (var i = 0; i < this.users.length; i++) {
if (this.users[i].id == user.id) {
this.$set(this.users, i, user);
this.users[i] = user;
break;
}
}
Expand Down

0 comments on commit 084f701

Please sign in to comment.