[Feature] Use Structure Void instead of Air

[JustAHuman-xD]

This PR simply sets the block to be a structure void instead of air when the plants or bushes grow. The reason for this is to allow other plugins such as SlimeHUD to properly recognize the plant. It also helps prevent interactions that may other wise break the plant such as piston pushes. (The point of leaving the listeners for that in is that any old plants won't be structure void)

I've also added a line to set the block to air in the case of killing a bush, as now if its not air it will be a structure void instead. Unless there is a specific reason it doesn't do this already I think this is meant to be here.

[JustAHuman-xD]

Working on testing this as we speak 👍

[JustAHuman-xD]

Water not being a problem:

Piston Behavior:

SlimeHUD installed:

Can still pass through:

Other testing:
Both bushes and plants that do not have a structure void work as intended.
Structure void is removed properly when breaking and appears properly when placing.

Is there anything left I should test?

[J3fftw1]

Will review this later but for some reason we decided not to use structure void blocks. I don’t know the reason for it anymore

[Sefiraat]

I don’t think we decided to not use them but instead were informed of their usefulness too late into proceedings, possibly even after go live. Either way I’m all for this and the other PR and will review later today.

[Bunnky]

I've found bushes have similar issues as plants in regards to the unsafelyKillItem method. To fix this, I've added:

} else if (slimefunItem instanceof CultivationBush bush) {
location.getWorld().dropItem(location, bush.getItem().clone());
bush.removeBushDisplayGroup(location);
BlockStorage.clearBlockInfo(location);
location.getBlock().setType(Material.AIR);
}

Like most things, I'm not 100% this is efficient, but it's been working for us for a while

[JustAHuman-xD]

?

[Bunnky]

Ignore me, its been a long day :D I was thinking of something else that's not in scope here, apologies!

For reference I was thinking about

Cultivation/src/main/java/dev/sefiraat/cultivation/api/slimefun/items/plants/CultivationPlant.java

Line 155 in b1dfa47

public void onBreak(@NotNull BlockBreakEvent event) {

where I added event.getBlock().setType(Material.AIR); to stop a dupe