feat(envoy): use the healthcheck filter and a prestop hook to gracefully terminate Envoy #6194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakoush
approved these changes
Jan 15, 2025
k8s/helm-charts/seldon-core-v2-setup/templates/seldon-v2-components.yaml
Outdated
Show resolved
Hide resolved
k8s/helm-charts/seldon-core-v2-setup/templates/seldon-v2-components.yaml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Some clients will receive resets when
seldon-envoyis restarting. These can be reduced by slowing down the termination sequence and triggering readiness checks to fail, so the kubelet will remove the pod's endpoint from Service load balancing.Which issue(s) this PR fixes:
Fixes # INFRA-1254
Special notes for your reviewer:
Perhaps this should be improved in future with something that at least logs some information about the
preStopsequence.