Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): adding a patch for server/spec/replicas upon scaling request #6222

Merged

Conversation

driev
Copy link

@driev driev commented Jan 23, 2025

What this PR does / why we need it:

This adds a method to patch a server's replica count, which is called when a scaling request is received from the scheduler.

Which issue(s) this PR fixes:

Fixes # INFRA-1048

@driev driev requested review from sakoush and lc525 as code owners January 23, 2025 17:20
@sakoush sakoush added the v2 label Jan 23, 2025
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a minor comment around testing.

operator/scheduler/server_test.go Show resolved Hide resolved
operator/scheduler/server_test.go Show resolved Hide resolved
@driev driev merged commit 1120b34 into SeldonIO:v2 Jan 24, 2025
4 checks passed
@driev driev deleted the INFRA-1048/synchronised-model-server-autoscaling branch January 24, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants