Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(operator): Included LLM spec to CRD #6234

Merged
merged 18 commits into from
Jan 29, 2025

Conversation

RobertSamoilescu
Copy link

@RobertSamoilescu RobertSamoilescu commented Jan 27, 2025

What this PR does / why we need it:

This PR adds support for the llm tag in the model CRD. Similarly to the explainer tag, the llm tag allows to reference an inference model by the name. This specification is used in the PromptRuntime for the LLM Module.

Example usage:

apiVersion: mlops.seldon.io/v1alpha1
kind: Model
metadata:
  name: chat-completions
spec:
  storageUri: "gs://seldon-models/llm-runtimes/prompting-test/models/chat-completions/"
  llm:
    modelRef: tiny-llama
  requirements:
  - prompt

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

@CLAassistant
Copy link

CLAassistant commented Jan 27, 2025

CLA assistant check
All committers have signed the CLA.

@RobertSamoilescu RobertSamoilescu marked this pull request as draft January 27, 2025 13:24
@sakoush sakoush added the v2 label Jan 27, 2025
@RobertSamoilescu RobertSamoilescu marked this pull request as ready for review January 27, 2025 16:57
@RobertSamoilescu RobertSamoilescu requested review from sakoush and removed request for sakoush and lc525 January 27, 2025 18:49
@sakoush sakoush changed the title Included LLM spec to CRD feat(operator): Included LLM spec to CRD Jan 28, 2025
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general it looks good, I left some comments for consideration.

apis/mlops/scheduler/scheduler.proto Outdated Show resolved Hide resolved
scheduler/pkg/agent/repository/mlserver/mlserver.go Outdated Show resolved Hide resolved
scheduler/pkg/agent/repository/mlserver/mlserver.go Outdated Show resolved Hide resolved
scheduler/pkg/agent/repository/mlserver/mlserver.go Outdated Show resolved Hide resolved
@@ -96,6 +96,9 @@ func TestAsModelDetails(t *testing.T) {
Type: "anchor_tabular",
ModelRef: &incomeModel,
},
Llm: &LlmSpec{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I think that we should have a test case specific to LLM spec and not have it with explainer. In fact the user should not be able to set the two together and this can should be marked as invalid perhaps.

operator/apis/mlops/v1alpha1/model_types.go Show resolved Hide resolved
Copy link
Member

@sakoush sakoush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@RobertSamoilescu RobertSamoilescu merged commit 08fa567 into SeldonIO:v2 Jan 29, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants