-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert changes in video recorder #2603
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit 80310f0)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
9041f9d
to
c2110a2
Compare
Signed-off-by: Viet Nguyen Duc <[email protected]>
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
Bug fix
Description
Fixed session ID condition in video recording logic.
Ensured proper handling of recording state transitions.
Changes walkthrough 📝
video.sh
Fixed session ID handling in recording logic
Video/video.sh