feat: LC-368 stats backend #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typeWolffo
force-pushed
the
jw_feat_lc-368_stats_backend
branch
from
6e7e8e2 to
13eadd2
Compare
typeWolffo
commented
Nov 19, 2024
| @@ -120,7 +121,7 @@ export class AuthService { | |||
| const tokens = await this.getTokens(user); | |||
| return tokens; | |||
| } catch (error) { | |||
| throw new UnauthorizedException("Invalid refresh token"); | |||
| throw new ForbiddenException("Invalid refresh token"); | |||
There was a problem hiding this comment.
this probably should fix our problem with infinite /refresh requests
typeWolffo
commented
Nov 19, 2024
Comment on lines
170
to
171
| let correctAnswers = 0; | ||
| let wrongAnswers = 0; |
There was a problem hiding this comment.
@wielopolski any ideas on how to get this data in a better way?
There was a problem hiding this comment.
maybe
Suggested change
| let correctAnswers = 0; | |
| let wrongAnswers = 0; | |
| const correctAnswerCount = questionLessonItem.content.questionAnswers | |
| .filter(answer => Boolean(answer.isCorrect)) | |
| .length; | |
| const wrongAnswerCount = totalQuestions - correctAnswerCount |
typeWolffo
force-pushed
the
jw_feat_lc-368_stats_backend
branch
from
13eadd2 to
aad2dcf
Compare
typeWolffo
added
review me 👀
typeWolffo
force-pushed
the
jw_feat_lc-368_stats_backend
branch
from
aad2dcf to
34d6b10
Compare
piotr-pajak
approved these changes
Nov 19, 2024
wielopolski
approved these changes
Nov 19, 2024
Comment on lines
170
to
171
| let correctAnswers = 0; | ||
| let wrongAnswers = 0; |
There was a problem hiding this comment.
maybe
Suggested change
| let correctAnswers = 0; | |
| let wrongAnswers = 0; | |
| const correctAnswerCount = questionLessonItem.content.questionAnswers | |
| .filter(answer => Boolean(answer.isCorrect)) | |
| .length; | |
| const wrongAnswerCount = totalQuestions - correctAnswerCount |
typeWolffo
force-pushed
the
jw_feat_lc-368_stats_backend
branch
from
34d6b10 to
5bc8c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira issue(s)
https://selleolabs.atlassian.net/browse/LC-371
https://selleolabs.atlassian.net/browse/LC-375
https://selleolabs.atlassian.net/browse/LC-376
https://selleolabs.atlassian.net/browse/LC-377
https://selleolabs.atlassian.net/browse/LC-378
Overview