Fixed not skipping unknown spells and items in icon evaluation.

Sellorio · Mar 28, 2022 · ba34295 · ba34295
1 parent f7dae03
commit ba34295
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/scripts/publish.bat b/scripts/publish.bat
@@ -1,3 +1,4 @@
 CALL .\depublish.bat
 mkdir "C:\Program Files (x86)\World of Warcraft\_retail_\Interface\AddOns\MegaMacro"
-xcopy /e /i /exclude:..\.publishignore .. "C:\Program Files (x86)\World of Warcraft\_retail_\Interface\AddOns\MegaMacro"
+xcopy /e /i /exclude:..\.publishignore .. "C:\Program Files (x86)\World of Warcraft\_retail_\Interface\AddOns\MegaMacro"
+PAUSE
diff --git a/src/engine/mega-macro-icon-evaluator.lua b/src/engine/mega-macro-icon-evaluator.lua
@@ -126,8 +126,12 @@ local function ComputeMacroIcon(macro, staticTexture, isStaticTextureFallback)
 
                 if ability ~= nil then
                     effectType, effectId, effectName, icon = GetAbilityData(ability)
-                    target = tar
-                    break
+
+                    -- skip spells or items that do not exist
+                    if effectType ~= "unknown" then
+                        target = tar
+                        break
+                    end
                 end
             elseif command.Type == "castsequence" then
                 local sequenceCode, tar = SecureCmdOptionParse(command.Body)