Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert changing config variables ($srfg to $wgSrfg) #848

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

robinwiel
Copy link
Contributor

This reverts the remainder of config variables from Semantic Result Formats (starting with "srfg") that were refactored to start with "wgSrfg". These config variables do not exist, and therefore some functionality does not work anymore.

The previous reverts were done in this issue: #842

The refactoring was done in commit 5515deb.

@gesinn-it-ilm Could you have a look?

@YOUR1
Copy link
Contributor

YOUR1 commented Aug 14, 2024

I don't think the failing tests are a problem of this branch...

@gesinn-it-ilm
Copy link
Contributor

@robinwiel - I have reverted all the config var in previous state before the mentioned commit, and tested it. So far looks good. It will be commited in 15 minutes. Just pull the latest changes from SRF and test it on your fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants