Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove front-end from jest projects #3654

Merged
merged 1 commit into from
Sep 12, 2022
Merged

Conversation

RC-Lee
Copy link
Contributor

@RC-Lee RC-Lee commented Sep 10, 2022

Issue This PR Addresses

Fixes #3643

Type of Change

  • Bugfix: Change which fixes an issue

Description

As mentioned in the issue, this will allow the pnpm jest script to run without crashing.

A follow-up issue will be written.

Steps to test the PR

  • pnpm jest

@gitpod-io
Copy link

gitpod-io bot commented Sep 10, 2022

@RC-Lee
Copy link
Contributor Author

RC-Lee commented Sep 10, 2022

Follow up issue #3655

jest.config.js Outdated
@@ -4,7 +4,8 @@ module.exports = {
...baseConfig,
projects: [
// Our front-end
'<rootDir>/src/web/app/jest.config.js',
// To do: Add front-end tests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the URL to the issue #3655 here in this comment too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. Added.

Copy link
Contributor

@humphd humphd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vercel error is #3310 and not related.

@RC-Lee RC-Lee merged commit 07e530a into Seneca-CDOT:master Sep 12, 2022
@RC-Lee RC-Lee deleted the issue#3643 branch October 5, 2022 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jest crashes with Nextjs v12.1.6
3 participants