test minor DT version creation w/ migr. expression

#1116
SerNet · Nov 27, 2024 · 8d3009f · 8d3009f
1 parent 2957407
commit 8d3009f
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 4 deletions.
diff --git a/veo-rest/src/restTest/groovy/org/veo/rest/test/DomainRestTest.groovy b/veo-rest/src/restTest/groovy/org/veo/rest/test/DomainRestTest.groovy
@@ -54,7 +54,10 @@ abstract class DomainRestTest extends VeoRestTest {
                             attributeDefinitions: [
                                 needsGlasses: [
                                     type: "boolean",
-                                ]
+                                ],
+                                nightBlind: [
+                                    type: "boolean"
+                                ],
                             ]
                         ]
                     ]

diff --git a/veo-rest/src/restTest/groovy/org/veo/rest/test/DomainTemplateVersioningRestTest.groovy b/veo-rest/src/restTest/groovy/org/veo/rest/test/DomainTemplateVersioningRestTest.groovy
@@ -121,16 +121,23 @@ class DomainTemplateVersioningRestTest extends DomainRestTest {
             customAspects.sight.attributeDefinitions.remove("needsGlasses")
             customAspects.sight.attributeDefinitions.needsReadingGlasses = [type: "boolean"]
             customAspects.sight.attributeDefinitions.needsDistanceSpecs = [type: "boolean"]
+            customAspects.sight.attributeDefinitions.remove("nightBlind")
+            customAspects.sight.attributeDefinitions.nightVision = [type: "boolean"]
+
             put("/content-creation/domains/$owner.domainId_1_0_0/element-type-definitions/person", it, null, 204, CONTENT_CREATOR)
         }
 
         then: "a template cannot be created without migration steps"
         ["1.0.1", "1.1.0", "2.0.0"].each{
-            assert post("/content-creation/domains/$domainId_1_0_0/template", [version: it], 422, CONTENT_CREATOR)
-            .body.message == "Migration definition not suited to update from old domain template 1.0.0: Missing migration steps: Removed attribute 'needsGlasses' of custom aspect 'sight' for type person"
+            with(post("/content-creation/domains/$domainId_1_0_0/template", [version: it], 422, CONTENT_CREATOR)
+            .body.message) {
+                it.startsWith("Migration definition not suited to update from old domain template 1.0.0: Missing migration steps:")
+                it.contains("Removed attribute 'needsGlasses' of custom aspect 'sight' for type person")
+                it.contains("Removed attribute 'nightBlind' of custom aspect 'sight' for type person")
+            }
         }
 
-        when: "adding a migration step"
+        when: "adding migration steps"
         put("/content-creation/domains/$domainId_1_0_0/migrations", [
             [
                 id: "split-needsGlasses",
@@ -157,6 +164,38 @@ class DomainTemplateVersioningRestTest extends DomainRestTest {
                         attribute: "needsDistanceSpecs"
                     ]
                 ]
+            ],
+            [
+                id: "negate-night-blindness",
+                description: [en: "Things have changed."],
+                oldDefinitions: [
+                    [
+                        type: "customAspectAttribute",
+                        elementType: "person",
+                        customAspect: "sight",
+                        attribute: "nightBlind"
+                    ]
+                ],
+                newDefinitions: [
+                    [
+                        type: "customAspectAttribute",
+                        elementType: "person",
+                        customAspect: "sight",
+                        attribute: "nightVision",
+                        migrationExpression: [
+                            type: "equals",
+                            left: [
+                                type: "customAspectAttributeValue",
+                                customAspect: "sight",
+                                attribute: "nightBlind",
+                            ],
+                            right: [
+                                type: "constant",
+                                value: false,
+                            ]
+                        ]
+                    ],
+                ]
             ]
         ], null, 200)
 
@@ -210,6 +249,12 @@ class DomainTemplateVersioningRestTest extends DomainRestTest {
                         elementType: "person",
                         customAspect: "sight",
                         attribute: "needsReadingGlasses",
+                    ],
+                    [
+                        type: "customAspectAttribute",
+                        elementType: "person",
+                        customAspect: "sight",
+                        attribute: "nightVision",
                     ]
                 ],
                 newDefinitions: [
@@ -224,6 +269,12 @@ class DomainTemplateVersioningRestTest extends DomainRestTest {
                         elementType: "person",
                         customAspect: "eyeSight",
                         attribute: "needsDistanceSpecs"
+                    ],
+                    [
+                        type: "customAspectAttribute",
+                        elementType: "person",
+                        customAspect: "eyeSight",
+                        attribute: "nightVision",
                     ]
                 ]
             ]