Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EFI Prekernel (3/N): Kernel/EFI: Add EFI service and protocol headers #24985

Merged
merged 8 commits into from
Nov 15, 2024

Conversation

spholz
Copy link
Member

@spholz spholz commented Sep 2, 2024

These headers will be used by the EFI Prekernel to communicate with the platform firmware.
The definitions are adapted from the UEFI specification to match our code style.

This PR does not depend on any of the other EFI Prekernel PRs.

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label Sep 2, 2024
Copy link

stale bot commented Sep 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Sep 28, 2024
@spholz spholz removed the stale label Sep 29, 2024
Copy link

stale bot commented Nov 5, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

@stale stale bot added the stale label Nov 5, 2024
Copy link
Contributor

@Hendiadyoin1 Hendiadyoin1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I still have a review pending, weird

Kernel/Firmware/EFI/EFI.h Outdated Show resolved Hide resolved
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks harmless enough :)

Kernel/Firmware/EFI/EFI.h Outdated Show resolved Hide resolved
Kernel/Firmware/EFI/Protocols/ConsoleSupport.h Outdated Show resolved Hide resolved
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just two (types) of followup question.

Kernel/Firmware/EFI/EFI.h Show resolved Hide resolved
Kernel/Firmware/EFI/Protocols/MediaAccess.h Show resolved Hide resolved
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
These definitions are adapted from the UEFI spec to match our code
style.
Copy link
Member

@timschumi timschumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, waiting for CI one last time. (Let's see if I need to rebase this manually, GitHub claims that I do.)

@timschumi timschumi merged commit 61244cd into SerenityOS:master Nov 15, 2024
16 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label Nov 15, 2024
@spholz spholz deleted the efi-prekernel-3 branch November 15, 2024 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants