Shell+LibLine: Some nice fixes #25404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a rendering issue where the first line of the prompt overwrites a line with "% ...", which leaves the "%" in the terminal if the prompt starts with "\n".
github-actions
bot
added
the
👀 pr-needs-review
nico
reviewed
Nov 17, 2024
| @@ -2106,7 +2112,7 @@ Result<Vector<size_t, 2>, Editor::Error> Editor::vt_dsr() | |||
| if (m_input_error.has_value()) | |||
| return m_input_error.value(); | |||
|
|
|||
| fputs("\033[6n", stderr); | |||
| fputs("\033[6n\n", stderr); | |||
There was a problem hiding this comment.
Is this in here intentionally? Looks somewhat unrelated to the commit message from a distance.
There was a problem hiding this comment.
It's intentional, should be a separate commit though, will fix.
The terminal won't be in any known state, so handling these events immediately is likely to cause desync or errors.
This generally yields nicer results around the bottom row of the terminal.
alimpfard
force-pushed
the
shell-a-line
branch
from
f0bab3c
to
1c4adde
Compare
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.