Patch du bug du /settings et mailbox + cache #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Faire un cache |
|
(Pas de requests SQL h24) |
|
revérifiez mon code pour voir si ça marche bien SVP |
Tu toi test normalement |
|
de quoi ? |
|
bah faut pas |
|
Toujours pas, quand le joueur ce connecte tu load toujours la db |
|
non |
iambibi
approved these changes
Oct 18, 2024
gab4000
changed the title
|
tu as bien test avec un second compte ? |
# Conflicts: # src/main/java/fr/communaywen/core/AywenCraftPlugin.java
iambibi
reviewed
Oct 23, 2024
src/main/java/fr/communaywen/core/adminshop/menu/buy/AdminShopBuy.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/communaywen/core/mailboxes/menu/letter/SendingLetter.java
Show resolved
Hide resolved
|
|
||
| @EventHandler | ||
| public void onJoin(PlayerJoinEvent e) { | ||
| Bukkit.getScheduler().runTaskAsynchronously(this.plugin, () -> { |
There was a problem hiding this comment.
ta boucle est innutile elle va juste mettre Player dans un autre thread et le reste sur le principal thread
|
mais? pourquoi avoir rechanger le taux max d'item? |
|
bon laisse tomber je laisse la main au autres |
gab4000
changed the title
|
🫤 |
|
regarde les review et ce seras good |
iambibi
approved these changes
Nov 1, 2024
AxenoDev
reviewed
Nov 2, 2024
src/main/java/fr/communaywen/core/settings/SettingsListener.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/communaywen/core/mailboxes/menu/letter/SendingLetter.java
Outdated
Show resolved
Hide resolved
src/main/java/fr/communaywen/core/mailboxes/menu/letter/SendingLetter.java
Outdated
Show resolved
Hide resolved
|
c bon au cas ou |
|
a merge, je pense que les 2 joueurs actifs sur le serveur seront content d'avoir leur mailbox |
|
Good @AxenoDev ? |
AxenoDev
approved these changes
Nov 21, 2024
Xernas78
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avez vous lu le Code de Conduite?: oui
Votre code se compile t-il en local ?: oui
Avez-vous supprimez les imports inutilisés ?: oui
Décrivez vos changements
Clairement et avec des screenshots si nécessaires
Ecriture des paramètres automatique lors de la connexion pour ne pas retourner null lors de l'ouverture des paramètres
Ajout d'un cache pour éviter les requêtes SQL permanentes
Réparation du /players
Réparation de la mailbox
Nouveau namespace pour le /settings :
Pensez à retirer le namespace omc_settings, s'il existe et de mettre celui là
settings.zip