Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: address #101 and #102 #103

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: address #101 and #102 #103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0929e73
fix: #101 pip version
vetsin Apr 10, 2024
e65fff2
fix: #102 incorrect Optional type
vetsin Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions poetry.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ python = "^3.8"
requests = "2.31.0"
requests-oauthlib = { version = ">=1.2.0", optional = true}
certifi = "2023.7.22"
pip = "^23.3.1"
pip = ">=23.3.1"
urllib3 = "^2.0.7"

[tool.poetry.extras]
Expand Down
4 changes: 2 additions & 2 deletions pysnc/record.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,7 +567,7 @@ def get(self, name, value=None) -> bool:
self.query()
return self.next()

def insert(self) -> Optional[str]:
def insert(self) -> Optional[GlideElement]:
"""
Insert a new record.

Expand All @@ -591,7 +591,7 @@ def insert(self) -> Optional[str]:
rjson = response.json()
raise InsertException(rjson['error'] if 'error' in rjson else f"{code} response on insert -- expected 201", status_code=code)

def update(self) -> Optional[str]:
def update(self) -> Optional[GlideElement]:
"""
Update the current record.

Expand Down
Loading