Step Metadata #26
Merged
Step Metadata #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
tests are still red, working on it |
jpt-sn
reviewed
Sep 24, 2024
tapeagents/core.py
Outdated
|
|
||
| def llm_dict(self) -> dict: | ||
| return self.model_dump(exclude={"prompt_id", "task", "by"}, exclude_none=True) | ||
| def task(self, task: str) -> Self: |
There was a problem hiding this comment.
Probably, I want to discuss that with Dima one more time to make things more clear in my head :)
There was a problem hiding this comment.
I see that this method mutates the object, so at the very least I'd call it set_task, but @jpt-sn 's comment is more important.
There was a problem hiding this comment.
changed to .by_node(). Are you ok with that name?
rizar
requested changes
Sep 25, 2024
Co-authored-by: Dzmitry Bahdanau <[email protected]>
rizar
approved these changes
Sep 25, 2024
|
it's amazing to see it done!!! thanks, @ollmer! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
move prompt id, task and by to the step metadata