Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update methods for Seshat page navigation on world map #221

Merged
merged 7 commits into from
Jan 11, 2025
Merged

Conversation

edwardchalstrey1
Copy link

@edwardchalstrey1
Copy link
Author

@MajidBenam Could you take a look at this suggestion which I have added to the world map? I have put seshatdata.com onto this new branch.

Actually I think I have may have got your suggestion the opposite way around, but maybe compare the hover functionality now with seshat-db.com and see what you think. The difference is basically that you now don't need to click a polity for it to remain in the top left after hover - but this actually makes it if anything harder to reach the box without accidentally hovering over another polity, so I could remove that change.

The other new change is that I have added the Seshat page links directly in the legend as well, which gives you another way to reach Seshat pages. But also don't forget the fastest way to get there is to double click a polity shape.

Let me know your thoughts :)

@MajidBenam
Copy link
Collaborator

I like the new style and the fact that you can also go to pages from the selection box. I think that will do the job. I did not know, that double clicking takes us to the page as well. I think it is good now. I will make sure that the changes are reflected on seshat-db.com as well.

@MajidBenam MajidBenam merged commit 4027acb into dev Jan 11, 2025
1 check passed
@edwardchalstrey1
Copy link
Author

I like the new style and the fact that you can also go to pages from the selection box. I think that will do the job. I did not know, that double clicking takes us to the page as well. I think it is good now. I will make sure that the changes are reflected on seshat-db.com as well.

@MajidBenam thanks - on a later commit in this PR that is now merged (but wasn't on seshatdata.com) I restored the previous way of handling the "mouseout", as per my comment above, so when you update seshat-db it will behave as before, which for the reason I explained above I think is the best. Can easily modify this behaviour later if we like

@edwardchalstrey1 edwardchalstrey1 deleted the fix-219 branch January 13, 2025 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

✨ [Feature request] - <Hovering over polities in maps>
2 participants