Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace route notation to be SF6 compatible, and use path_name parameter for admin prefix #90

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

delyriand
Copy link

@delyriand delyriand commented Jan 29, 2024

Avoid 404s if the admin path is modified via the env variable

@loevgaard
Copy link
Member

Can you rebase on master? I just merged #88

@delyriand
Copy link
Author

@loevgaard done

@loevgaard
Copy link
Member

Is it possible for you to fix the build?

@delyriand
Copy link
Author

@loevgaard it's not linked to this PR, there are the same errors on master: https://github.com/Setono/SyliusFeedPlugin/actions/runs/7711190968

I don't have time to watch your build

@loevgaard
Copy link
Member

Okay, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants