Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Bpost and PostNL support #63

Open
wants to merge 4 commits into
base: 1.x
Choose a base branch
from

Conversation

kenny-inventis
Copy link

Add support for Bpost and PostNL.

@kenny-inventis kenny-inventis force-pushed the feature/add-bpost-and-postnl-integration branch from 6c14759 to d7d162e Compare May 24, 2022 14:29
@kenny-inventis kenny-inventis force-pushed the feature/add-bpost-and-postnl-integration branch 2 times, most recently from f1c9bab to 8d421c2 Compare June 2, 2022 08:41
@loevgaard
Copy link
Member

Can you rebase onto master :)

@codecov
Copy link

codecov bot commented Jun 14, 2022

Codecov Report

Merging #63 (f3a6712) into master (eeacac9) will decrease coverage by 1.77%.
The diff coverage is 12.25%.

❗ Current head f3a6712 differs from pull request most recent head 3739dae. Consider uploading reports for the commit 3739dae to get more accurate results

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage     16.45%   14.67%   -1.78%     
- Complexity      241      415     +174     
============================================
  Files            37       51      +14     
  Lines           772     1329     +557     
============================================
+ Hits            127      195      +68     
- Misses          645     1134     +489     
Impacted Files Coverage Δ
src/Client/Bpost/Client.php 0.00% <0.00%> (ø)
src/Client/PostNL/Client.php 0.00% <0.00%> (ø)
...ndencyInjection/Compiler/RegisterFactoriesPass.php 0.00% <0.00%> (ø)
...dencyInjection/Compiler/RegisterHttpClientPass.php 0.00% <0.00%> (ø)
src/Exception/RequestFailedException.php 0.00% <0.00%> (ø)
src/Factory/Bpost/ServicePointQueryFactory.php 0.00% <0.00%> (ø)
src/Factory/PostNL/ServicePointQueryFactory.php 0.00% <0.00%> (ø)
src/Model/Query/Bpost/ServicePointQuery.php 0.00% <0.00%> (ø)
src/Model/Query/PostNL/ServicePointLookup.php 0.00% <0.00%> (ø)
src/Model/Query/PostNL/ServicePointQuery.php 0.00% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eeacac9...3739dae. Read the comment docs.

@kenny-inventis kenny-inventis force-pushed the feature/add-bpost-and-postnl-integration branch from f3a6712 to 3739dae Compare June 20, 2022 06:46
@vvasiloi
Copy link

@loevgaard could you please give this a try? I really don't want to use a fork forever.

@loevgaard loevgaard changed the base branch from master to 1.x January 6, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants