Do not throw if channel does not exist on current request

Setono · Aug 7, 2023 · d4a498d · d4a498d
1 parent 7e192b0
commit d4a498d
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/composer-require-checker.json b/composer-require-checker.json
@@ -21,6 +21,7 @@
     "Sylius\\Bundle\\TaxonomyBundle\\Form\\Type\\TaxonTranslationType",
     "Sylius\\Bundle\\UiBundle\\Menu\\Event\\MenuBuilderEvent",
     "Sylius\\Component\\Channel\\Context\\ChannelContextInterface",
+    "Sylius\\Component\\Channel\\Context\\ChannelNotFoundException",
     "Sylius\\Component\\Channel\\Model\\ChannelAwareInterface",
     "Sylius\\Component\\Channel\\Model\\ChannelInterface",
     "Sylius\\Component\\Channel\\Model\\ChannelsAwareInterface",

diff --git a/src/EventListener/ControllerSubscriber.php b/src/EventListener/ControllerSubscriber.php
@@ -7,6 +7,7 @@
 use Doctrine\Persistence\ObjectManager;
 use Setono\SyliusRedirectPlugin\Resolver\RedirectionPathResolverInterface;
 use Sylius\Component\Channel\Context\ChannelContextInterface;
+use Sylius\Component\Channel\Context\ChannelNotFoundException;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\HttpKernel\Event\ControllerEvent;
 use Symfony\Component\HttpKernel\KernelEvents;
@@ -45,9 +46,15 @@ public static function getSubscribedEvents(): array
     public function onKernelController(ControllerEvent $event): void
     {
         $request = $event->getRequest();
+        $channel = null;
+
+        try {
+            $channel = $this->channelContext->getChannel();
+        } catch (ChannelNotFoundException $e) {
+        }
         $redirectionPath = $this->redirectionPathResolver->resolveFromRequest(
             $request,
-            $this->channelContext->getChannel()
+            $channel
         );
 
         if ($redirectionPath->isEmpty()) {

diff --git a/src/EventListener/NotFoundSubscriber.php b/src/EventListener/NotFoundSubscriber.php
@@ -8,6 +8,7 @@
 use Setono\MainRequestTrait\MainRequestTrait;
 use Setono\SyliusRedirectPlugin\Resolver\RedirectionPathResolverInterface;
 use Sylius\Component\Channel\Context\ChannelContextInterface;
+use Sylius\Component\Channel\Context\ChannelNotFoundException;
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Event\ExceptionEvent;
@@ -57,11 +58,17 @@ public function onKernelException(ExceptionEvent $event): void
         if (!$throwable instanceof HttpException || $throwable->getStatusCode() !== Response::HTTP_NOT_FOUND) {
             return;
         }
+        $channel = null;
+
+        try {
+            $channel = $this->channelContext->getChannel();
+        } catch (ChannelNotFoundException $e) {
+        }
 
         $request = $event->getRequest();
         $redirectionPath = $this->redirectionPathResolver->resolveFromRequest(
             $request,
-            $this->channelContext->getChannel(),
+            $channel,
             true
         );