Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cross-env package for windows compatibility #1108

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

sammwyy
Copy link
Contributor

@sammwyy sammwyy commented Nov 3, 2024

Proposed changes

Added cross-env prefix to all environment variables in package.json to ensure compatibility with Windows development.

Types of changes

What types of changes does your code introduce to 7TV? Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged

Further comments

I would like to contribute to the development of the project, however my work environment is Windows (Weird, I know), and I preferred to do this PR separately rather than leaving it together with a feature PR.

@CLAassistant
Copy link

CLAassistant commented Nov 3, 2024

CLA assistant check
All committers have signed the CLA.

@Excellify Excellify added the skip changelog check This pull request does not need a changelog entry label Nov 11, 2024
@Excellify
Copy link
Collaborator

Excellify commented Nov 11, 2024

This should be fine

@Excellify Excellify merged commit f7aba14 into SevenTV:master Nov 11, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changelog check This pull request does not need a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants