Improve insufficient scopes handling in OciRegistryApi

SgtSilvio · Jul 22, 2024 · 7253069 · 7253069
1 parent 1412fce
commit 7253069
Showing 1 changed file with 8 additions and 7 deletions.
diff --git a/src/main/kotlin/io/github/sgtsilvio/gradle/oci/internal/registry/OciRegistryApi.kt b/src/main/kotlin/io/github/sgtsilvio/gradle/oci/internal/registry/OciRegistryApi.kt
@@ -577,15 +577,16 @@ internal class OciRegistryApi(httpClient: HttpClient) {
                 }
                 val registryToken = OciRegistryToken(token)
                 val grantedScopes = registryToken.claims?.scopes
-                if ((grantedScopes == null) || (grantedScopes == key.scopes)) {
-                    registryToken
-                } else {
-                    tokenCache.asMap().putIfAbsent(
-                        key.copy(scopes = grantedScopes),
-                        CompletableFuture.completedFuture(registryToken),
-                    )
+                if ((grantedScopes != null) && (grantedScopes != key.scopes)) {
+                    if (grantedScopes.isNotEmpty()) {
+                        tokenCache.asMap().putIfAbsent(
+                            key.copy(scopes = grantedScopes),
+                            CompletableFuture.completedFuture(registryToken),
+                        )
+                    }
                     throw InsufficientScopesException(key.scopes, grantedScopes)
                 }
+                registryToken
             }
         }.map { encodeBearerAuthorization(it.token) }
     }