Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floating checkmark, closes #4 #22

Merged
merged 6 commits into from
Sep 11, 2024
Merged

Conversation

Exr0n
Copy link
Member

@Exr0n Exr0n commented Sep 10, 2024

closes #4

@Jemoka Jemoka self-requested a review September 10, 2024 20:11
@Jemoka Jemoka added the components UI components label Sep 10, 2024
@Jemoka
Copy link
Member

Jemoka commented Sep 10, 2024

looks bascially good, two things:

image

is sad, we can either

  • hide the side button when task is expanded
  • remove the button entirely from the expanded view

also in the dev environment it seems like its finicky to get the onhover to show up on the first task of the browse view; can you reproduce?

thabks

Copy link
Member

@Jemoka Jemoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see above

src/components/task.jsx Outdated Show resolved Hide resolved
@Exr0n Exr0n requested a review from Jemoka September 11, 2024 02:39
Copy link
Member

@Jemoka Jemoka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thabk

@Jemoka Jemoka merged commit 6736be7 into dev Sep 11, 2024
2 checks passed
@Jemoka Jemoka deleted the feat/floating_checkmark_twooooooooooooo branch September 11, 2024 02:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
components UI components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action view: on-hover "complete" checkmark action button without having to click into the task
2 participants