Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose generic target interface on every target interface #275

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

imLinguin
Copy link
Contributor

Finally got the use for TargetInterface. This will allow overlays to iterate over target devices to get their type - this is especially useful in cases like controller reordering or anything that relies on target device types

@pastaq
Copy link
Contributor

pastaq commented Feb 5, 2025

Finally got the use for TargetInterface. This will allow overlays to iterate over target devices to get their type - this is especially useful in cases like controller reordering or anything that relies on target device types

Just a note about this. We will need to implement controller reordering directly into InputPlumber. Because some targets need to be stopped during suspend (i.e. deck) they will come back in a different order on resume. I would not do this client side entirely, but instead rely on a dbus interface provided by InputPlumber to do the ordering.

src/input/target/mod.rs Outdated Show resolved Hide resolved
src/dbus/interface/target/mod.rs Outdated Show resolved Hide resolved
src/input/target/mod.rs Outdated Show resolved Hide resolved
@ShadowApex ShadowApex merged commit 78da613 into ShadowBlip:main Feb 10, 2025
1 check passed
Copy link

🎉 This PR is included in version 0.45.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants