fix(Search Bar): add keyboard support for search bar #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pastaq
reviewed
Dec 27, 2024
- Update search bar to use LineEdit instead of TextEdit - Add ability to move text cursor with OSK - Switch to library state upon keyboard input
ShadowApex
force-pushed
the
shadowapex/search-bar-fixes
branch
from
8adbfb4 to
243b6d2
Compare
pastaq
approved these changes
Dec 28, 2024
|
🎉 This PR is included in version 0.35.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for library search using the keyboard input method. It also switches to using the
LineEditnode as a base instead of theTextEditnode (which is typically used for multiline editing). It also adds the ability to move the text box cursor with the OSK directional buttons.Fixes #296