Merges the changes from the `release/3.0` branch to `release/4.0` branch · Shazwazza/Examine@f0e72bb

The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, gittools/actions/gitversion/[email protected], gittools/actions/gitversion/[email protected], actions/upload-artifact@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/

src/Examine.Core/Search/FacetLabel.cs#L41

Missing XML comment for publicly visible type or member 'FacetLabel.CompareTo(IFacetLabel)'

src/Examine.Lucene/Providers/LuceneTaxonomySearcher.cs#L60

'LuceneTaxonomySearcher.Dispose()' hides inherited member 'BaseLuceneSearcher.Dispose()'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.

src/Examine.Lucene/Providers/LuceneSearcher.cs#L53

'LuceneSearcher.Dispose()' hides inherited member 'BaseLuceneSearcher.Dispose()'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.

src/Examine.Lucene/Providers/LuceneIndex.cs#L37

Non-nullable field '_searcher' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

src/Examine.Lucene/Search/LuceneSearchExecutor.cs#L245

The variable 'sortedSetReaderState' is assigned but its value is never used

src/Examine.Lucene/Search/LuceneSearchExecutor.cs#L246

The variable 'fastTaxonomyFacetCounts' is assigned but its value is never used

src/Examine.Lucene/Providers/LuceneIndex.cs#L1212

Possible null reference return.

src/Examine.Lucene/Providers/LuceneIndex.cs#L1288

Possible null reference return.

src/Examine.Lucene/Directories/DirectoryFactory.cs#L8

Missing XML comment for publicly visible type or member 'GenericDirectoryFactory'

src/Examine.Lucene/Directories/FileSystemDirectoryFactory.cs#L9

Missing XML comment for publicly visible type or member 'FileSystemDirectoryFactory'

The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

src/Examine.Core/Search/FacetLabel.cs#L41

Nullability of reference types in type of parameter 'other' of 'int FacetLabel.CompareTo(IFacetLabel other)' doesn't match implicitly implemented member 'int IComparable<IFacetLabel>.CompareTo(IFacetLabel? other)' (possibly because of nullability attributes).

src/Examine.Core/Search/FacetLabel.cs#L41

Missing XML comment for publicly visible type or member 'FacetLabel.CompareTo(IFacetLabel)'

src/Examine.Core/Search/FacetLabel.cs#L41

Missing XML comment for publicly visible type or member 'FacetLabel.CompareTo(IFacetLabel)'

src/Examine.Lucene/Providers/LuceneTaxonomySearcher.cs#L60

'LuceneTaxonomySearcher.Dispose()' hides inherited member 'BaseLuceneSearcher.Dispose()'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.

src/Examine.Lucene/Providers/LuceneSearcher.cs#L53

'LuceneSearcher.Dispose()' hides inherited member 'BaseLuceneSearcher.Dispose()'. To make the current member override that implementation, add the override keyword. Otherwise add the new keyword.

src/Examine.Lucene/Providers/LuceneIndex.cs#L37

Non-nullable field '_searcher' must contain a non-null value when exiting constructor. Consider declaring the field as nullable.

src/Examine.Lucene/Search/LuceneSearchExecutor.cs#L245

The variable 'sortedSetReaderState' is assigned but its value is never used

src/Examine.Lucene/Search/LuceneSearchExecutor.cs#L246

The variable 'fastTaxonomyFacetCounts' is assigned but its value is never used

src/Examine.Lucene/Providers/LuceneIndex.cs#L1212

Possible null reference return.

src/Examine.Lucene/Providers/LuceneIndex.cs#L1288

Possible null reference return.