Remove filter chaining as not supported in lucene 5+

docs/articles/filtering.md

@@ -134,7 +134,7 @@ var results = query.Execute(QueryOptions.Default);
 
 This will return results where the field `SomeDouble` is within the range 0 - 100 (min value and max value included).
 
-## Booleans and Chains
+## Booleans
 
 ### Or
 
@@ -203,26 +203,6 @@ var results = searcher.CreateQuery()
  .Execute();
 ```
 
-### Chaining
-
-```csharp
-var searcher = myIndex.Searcher;
-var results = searcher.CreateQuery()
-   .WithFilter(
-    filter =>
-    {
-        filter.ChainFilters(chain =>
-            chain.Chain(ChainOperation.AND, chainedFilter => chainedFilter.NestedFieldValueExists("nodeTypeAlias")) //AND
-                    .Chain(ChainOperation.AND, chainedFilter => chainedFilter.NestedTermPrefix(new FilterTerm("nodeTypeAlias", "CWS_H")))
-                        .Chain(ChainOperation.OR, chainedFilter => chainedFilter.NestedTermFilter(new FilterTerm("nodeName", "my name")))
-                            .Chain(ChainOperation.ANDNOT, chainedFilter => chainedFilter.NestedTermFilter(new FilterTerm("nodeName", "someone elses name")))
-                                .Chain(ChainOperation.XOR, chainedFilter => chainedFilter.NestedTermPrefix(new FilterTerm("nodeName", "my")))
-                    );
-    })
-     .All()
- .Execute();
-```
-
 ## Spatial
 
 Examine supports Spatial Filtering.

src/Examine.Core/Search/IFilter.cs

@@ -5,13 +5,6 @@ namespace Examine.Search
 {
     public interface IFilter
     {
-        /// <summary>
-        /// Chain filters
-        /// </summary>
-        /// <param name="chain"></param>
-        /// <returns></returns>
-        IBooleanFilterOperation ChainFilters(Action<IFilterChain> chain);
-
         /// <summary>
         /// Term must match
         /// </summary>

src/Examine.Core/Search/INestedFilter.cs

@@ -5,13 +5,6 @@ namespace Examine.Search
 {
     public interface INestedFilter
     {
-        /// <summary>
-        /// Chain filters
-        /// </summary>
-        /// <param name="chain"></param>
-        /// <returns></returns>
-        INestedBooleanFilterOperation NestedChainFilters(Action<IFilterChain> chain);
-
         /// <summary>
         /// Term must match
         /// </summary>

src/Examine.Lucene/Search/LuceneFilter.cs

@@ -25,9 +25,6 @@ public LuceneFilter(LuceneSearchFilteringOperation search, Occur occurrence)
             _occurrence = occurrence;
         }
 
-        /// <inheritdoc/>
-        public IBooleanFilterOperation ChainFilters(Action<IFilterChain> chain) => _search.ChainFiltersInternal(chain, _occurrence);
-
         /// <inheritdoc/>
         public IBooleanFilterOperation TermFilter(FilterTerm term) => _search.TermFilterInternal(term,_occurrence);
 
@@ -46,9 +43,6 @@ public LuceneFilter(LuceneSearchFilteringOperation search, Occur occurrence)
         /// <inheritdoc/>
         public IBooleanFilterOperation QueryFilter(Func<INestedQuery, INestedBooleanOperation> inner, BooleanOperation defaultOp = BooleanOperation.And) => _search.QueryFilterInternal(inner, defaultOp, _occurrence);
 
-        /// <inheritdoc/>
-        INestedBooleanFilterOperation INestedFilter.NestedChainFilters(Action<IFilterChain> chain) => _search.NestedChainFiltersInternal(chain, _occurrence);
-
         /// <inheritdoc/>
         public INestedBooleanFilterOperation NestedTermFilter(FilterTerm term) => _search.NestedTermFilterInternal(term, _occurrence);
 

src/Examine.Lucene/Search/LuceneFilteringBooleanOperation.cs

@@ -35,9 +35,6 @@ public LuceneFilteringBooleanOperation(LuceneSearchFilteringOperation luceneSear
 
         #region IFilter
 
-        /// <inheritdoc/>
-        public override IBooleanFilterOperation ChainFilters(Action<IFilterChain> chain) => _search.ChainFilters(chain);
-
         /// <inheritdoc/>
         public override IBooleanFilterOperation TermFilter(FilterTerm term) => _search.TermFilter(term);
 

src/Examine.Lucene/Search/LuceneFilteringBooleanOperationBase.cs

@@ -87,9 +87,6 @@ internal Filter GetNestedFilterOp(
             return _search.Filters.Pop();
         }
 
-        /// <inheritdoc/>
-        public abstract IBooleanFilterOperation ChainFilters(Action<IFilterChain> chain);
-
         /// <inheritdoc/>
         public abstract IBooleanFilterOperation TermFilter(FilterTerm term);
 

src/Examine.Lucene/Search/LuceneSearchFiltering.cs

@@ -37,37 +37,8 @@ public LuceneSearchFilteringOperation(LuceneSearchQuery luceneSearchQuery)
         /// <returns></returns>
         protected override LuceneFilteringBooleanOperationBase CreateBooleanOp() => new LuceneFilteringBooleanOperation(this);
 
-        /// <summary>
-        /// Creates a new <see cref="FilterChainOpBase"/>
-        /// </summary>
-        /// <returns></returns>
-        protected override FilterChainOpBase CreateChainOp() => new FilterChainOp(this);
         #region IFilter
 
-        /// <inheritdoc/>
-        public override IBooleanFilterOperation ChainFilters(Action<IFilterChain> chain)
-        {
-            return ChainFiltersInternal(chain);
-        }
-
-        /// <inheritdoc/>
-        internal IBooleanFilterOperation ChainFiltersInternal(Action<IFilterChain> chain, Occur occurance = Occur.MUST)
-        {
-            if (chain is null)
-            {
-                throw new ArgumentNullException(nameof(chain));
-            }
-            var chaining = CreateChainOp();
-            chain.Invoke(chaining);
-            var chainedFilter = chaining.Build();
-            if (chainedFilter != null)
-            {
-                Filter.Add(chainedFilter, occurance);
-            }
-
-            return CreateBooleanOp();
-        }
-
         /// <inheritdoc/>
         public override IBooleanFilterOperation TermFilter(FilterTerm term) => TermFilterInternal(term);
 
@@ -292,9 +263,6 @@ internal IBooleanFilterOperation LongRangeFilterInternal(string field, long? min
 
         #region INestedFilter
 
-        /// <inheritdoc/>
-        protected override INestedBooleanFilterOperation NestedChainFilters(Action<IFilterChain> chain) => NestedChainFiltersInternal(chain);
-
         /// <inheritdoc/>
         protected override INestedBooleanFilterOperation NestedTermFilter(FilterTerm term) => NestedTermFilterInternal(term);
 
@@ -313,24 +281,6 @@ internal IBooleanFilterOperation LongRangeFilterInternal(string field, long? min
         /// <inheritdoc/>
         protected override INestedBooleanFilterOperation NestedQueryFilter(Func<INestedQuery, INestedBooleanOperation> inner, BooleanOperation defaultOp) => NestedQueryFilterInternal(inner, defaultOp);
 
-        /// <inheritdoc/>
-        internal INestedBooleanFilterOperation NestedChainFiltersInternal(Action<IFilterChain> chain, Occur occurance = Occur.MUST)
-        {
-            if (chain is null)
-            {
-                throw new ArgumentNullException(nameof(chain));
-            }
-            var chaining = new FilterChainOp(this);
-            chain.Invoke(chaining);
-            var chainedFilter = chaining.Build();
-            if (chainedFilter != null)
-            {
-                Filter.Add(chainedFilter, occurance);
-            }
-
-            return CreateBooleanOp();
-        }
-
         /// <inheritdoc/>
         internal INestedBooleanFilterOperation NestedTermFilterInternal(FilterTerm term, Occur occurance = Occur.MUST)
         {

src/Examine.Lucene/Search/LuceneSearchFilteringOperationBase.cs

@@ -68,15 +68,6 @@ public LuceneFilteringBooleanOperationBase LuceneFilter(Filter filter, BooleanOp
         /// <returns></returns>
         protected abstract LuceneFilteringBooleanOperationBase CreateBooleanOp();
 
-        /// <summary>
-        /// Creates a new <see cref="FilterChainOpBase"/>
-        /// </summary>
-        /// <returns></returns>
-        protected abstract FilterChainOpBase CreateChainOp();
-
-        /// <inheritdoc/>
-        public abstract IBooleanFilterOperation ChainFilters(Action<IFilterChain> chain);
-
         /// <inheritdoc/>
         public abstract IBooleanFilterOperation TermFilter(FilterTerm term);
 
@@ -95,9 +86,6 @@ public LuceneFilteringBooleanOperationBase LuceneFilter(Filter filter, BooleanOp
         /// <inheritdoc/>
         public abstract IBooleanFilterOperation QueryFilter(Func<INestedQuery, INestedBooleanOperation> inner, BooleanOperation defaultOp = BooleanOperation.And);
 
-        /// <inheritdoc/>
-        protected abstract INestedBooleanFilterOperation NestedChainFilters(Action<IFilterChain> chain);
-
         /// <inheritdoc/>
         protected abstract INestedBooleanFilterOperation NestedTermFilter(FilterTerm term);
 
@@ -119,9 +107,6 @@ public LuceneFilteringBooleanOperationBase LuceneFilter(Filter filter, BooleanOp
         /// <inheritdoc/>
         protected abstract INestedBooleanFilterOperation NestedSpatialOperationFilter(string field, ExamineSpatialOperation spatialOperation, Func<IExamineSpatialShapeFactory, IExamineSpatialShape> shape);
 
-        /// <inheritdoc/>
-        INestedBooleanFilterOperation INestedFilter.NestedChainFilters(Action<IFilterChain> chain) => NestedChainFilters(chain);
-
         /// <inheritdoc/>
         INestedBooleanFilterOperation INestedFilter.NestedTermFilter(FilterTerm term) => NestedTermFilter(term);