-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the most of metadata into PEP 621
-compliant pyproject.toml
.
#1006
Conversation
Add `pyproject.toml` according to PEP 517.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## devel #1006 +/- ##
=======================================
Coverage 54.49% 54.49%
=======================================
Files 210 210
Lines 21560 21560
Branches 3169 3169
=======================================
Hits 11750 11750
Misses 9255 9255
Partials 555 555 |
It partially overlaps with #975, I think. |
I'd be supportive of this. |
Yes pls update the branch and we need to merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only some minor things to be done
authors = [{name = "GPy Authors: https://github.com/SheffieldML/GPy/graphs/contributors", email = "[email protected]"},] | ||
license = {text = "BSD-3-Clause"} | ||
description = "The Gaussian Process Toolbox" | ||
readme = "README.rst" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
readme = "README.rst" | |
readme = "README.md" |
"Programming Language :: Python :: 3.5", | ||
"Programming Language :: Python :: 3.6", | ||
"Programming Language :: Python :: 3.7", | ||
"Programming Language :: Python :: 3.8", | ||
"Programming Language :: Python :: 3.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Programming Language :: Python :: 3.5", | |
"Programming Language :: Python :: 3.6", | |
"Programming Language :: Python :: 3.7", | |
"Programming Language :: Python :: 3.8", | |
"Programming Language :: Python :: 3.9", | |
"Programming Language :: Python :: 3.9", | |
"Programming Language :: Python :: 3.10", | |
"Programming Language :: Python :: 3.11", | |
"Programming Language :: Python :: 3.12", | |
"Programming Language :: Python :: 3.13", |
"scipy>=1.3.0; python_version >= '3.6'", | ||
"scipy>=1.3.0,<1.5.0; python_version < '3.6'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"scipy>=1.3.0; python_version >= '3.6'", | |
"scipy>=1.3.0,<1.5.0; python_version < '3.6'", | |
"scipy>=1.3.0,<=1.12.0" |
dependencies = [ | ||
"numpy>=1.7", | ||
"six", | ||
"paramz>=0.9.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"paramz>=0.9.0", | |
"paramz>=0.9.6", |
"matplotlib==3.3.4; python_version >= '3.6'", | ||
"matplotlib==3.0.0; python_version < '3.6'", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"matplotlib==3.3.4; python_version >= '3.6'", | |
"matplotlib==3.0.0; python_version < '3.6'", | |
"matplotlib>=3.3.4", |
Requires #1005