-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(create-booking): create client side modal for new booking #1621
feat(create-booking): create client side modal for new booking #1621
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The modal on the client and the one on the route are having different width, please make them consistent
- The actions in the client side modal are not consistent with the route, please make them consistent
- Add the new booking button and modal on the calendar page. That was the initial purpose of doing this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed 1 more thing we need to adjust.
For some reason the calendar component is dependent on some data for the modal. So if you open the modal, the calendar component re-renders and re-fetches. This shouldnt be the case as it looks bad and its also a performance issue. Opening the new-booking modal shouldn't trigger a re-render on the calendar component.
closes #1610