Remove all conditional logic around App Management being disabled

[amcaplan]

WHY are these changes introduced?

Completes https://github.com/Shopify/develop-app-inner-loop/issues/2343

Removes the App Management feature flag and makes it a default part of the CLI's functionality. This should be merged when App Management is ready to be rolled out to all eligible organizations.

WHAT is this pull request doing?

• Removes the USE_APP_MANAGEMENT_API environment variable and related checks
• Removes most behavior implementing a special case where App Management is disabled
  • ... with the exception of when using a Partners CLI token, in which case we need to access only Partners and not App Management

How to test your changes?

1. Deploy an app using shopify app deploy --reset (or you can start all the way back from app init)
2. Verify organizations are fetched from both Partners and App Management APIs
3. Test app creation and management workflows to ensure they work without the feature flag

Checklist

• I've considered possible cross-platform impacts (Mac, Linux, Windows)
• I've considered possible documentation changes

[amcaplan]

• Remove all conditional logic around App Management being disabled #5004 👈 (View in Graphite)
• Centralize gating of the App Management API #5003
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

We detected some changes at packages/*/src and there are no updates in the .changeset.
If the changes are user-facing, run "pnpm changeset add" to track your changes and include them in the next release CHANGELOG.

[github-actions]

This PR seems inactive. If it's still relevant, please add a comment saying so. Otherwise, take no action.
→ If there's no activity within a week, then a bot will automatically close this.
Thanks for helping to improve Shopify's dev tooling and experience.

[amcaplan]

still relevant

[github-actions]

Coverage report

St.❔	Category	Percentage	Covered / Total
🟡	Statements	75.24% (+0.06% 🔼)	8880/11802
🟡	Branches	70.42% (+0.11% 🔼)	4328/6146
🟡	Functions	75.06% (+0% 🔼)	2326/3099
🟡	Lines	75.8% (+0.08% 🔼)	8394/11074

Show files with reduced coverage 🔻

St.❔	File	Statements	Branches	Functions	Lines
🟢	... / bundle.ts	100%	50% (-10% 🔻)	100%	100%
🟡	... / ui.tsx	70.59% (-11.55% 🔻)	60% (-12.22% 🔻)	100%	73.33% (-11.28% 🔻)
🟢	... / urls.ts	82.57%	77.5% (-0.81% 🔻)	75%	84.47%
🟢	... / app-event-watcher.ts	93.83% (-1.23% 🔻)	86.49% (-2.7% 🔻)	90.48%	98.61%
🟢	... / session.ts	89.6% (+6.59% 🔼)	77.17% (+4.45% 🔼)	91.67% (-1.19% 🔻)	88.98% (+6.22% 🔼)
🟡	... / exchange.ts	76.36% (-0.42% 🔻)	62.96%	77.78%	75.93% (-0.44% 🔻)
🟢	... / scopes.ts	95.65%	82.35% (-0.98% 🔻)	100%	95.45%
🟡	... / local.ts	62.96%	52% (-0.94% 🔻)	47.83%	62.96%

Test suite run success

2002 tests passing in 904 suites.

Report generated by 🧪jest coverage report action from de4d15e

[gonzaloriestra]

What happens if a Partners organization has already been migrated to BP? The CLI would show it twice in the list of orgs? For that reason, I was merging them here.

Then, if duplicated, we should choose which one to use depending on the app migration status.

[amcaplan]

What happens if a Partners organization has already been migrated to BP? The CLI would show it twice in the list of orgs? For that reason, I was merging them here.

Then, if duplicated, we should choose which one to use depending on the app migration status.

This is a great question. I don't think it's relevant to this PR, though, as that behavior is unaffected. It would be worth checking why that deduplication was dropped.

[dmerand]

It's worth renaming this test to not reference USE_APP_MANAGEMENT_API.

[github-actions]

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

• Some seemingly private modules might be re-exported through public modules.
• If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts

@@ -31,7 +31,6 @@ export declare const environmentVariables: {
     otelURL: string;
     themeKitAccessDomain: string;
     json: string;
-    useAppManagement: string;
 };
 export declare const defaultThemeKitAccessDomain = "theme-kit-access.shopifyapps.com";
 export declare const systemEnvironmentVariables: {

packages/cli-kit/dist/private/node/api/headers.d.ts

@@ -1,6 +1,6 @@
 import { ExtendableError } from '../../../public/node/error.js';
 import https from 'https';
-export declare class RequestClientError extends ExtendableError {
+declare class RequestClientError extends ExtendableError {
     statusCode: number;
     constructor(message: string, statusCode: number);
 }
@@ -25,4 +25,5 @@ export declare function buildHeaders(token?: string): {
  * if the service is running in a Spin environment, the attribute "rejectUnauthorized" is
  * set to false
  */
-export declare function httpsAgent(): Promise<https.Agent>;
\ No newline at end of file
+export declare function httpsAgent(): Promise<https.Agent>;
+export {};
\ No newline at end of file

packages/cli-kit/dist/private/node/session/scopes.d.ts

@@ -5,7 +5,7 @@ import { API } from '../api.js';
  * @param extraScopes - custom user-defined scopes
  * @returns Array of scopes
  */
-export declare function allDefaultScopes(extraScopes?: string[], systemEnvironment?: NodeJS.ProcessEnv): string[];
+export declare function allDefaultScopes(extraScopes?: string[]): string[];
 /**
  * Generate a flat array with the default scopes for the given API plus
  * any custom scope defined by the user
@@ -13,4 +13,4 @@ export declare function allDefaultScopes(extraScopes?: string[], systemEnvironme
  * @param extraScopes - custom user-defined scopes
  * @returns Array of scopes
  */
-export declare function apiScopes(api: API, extraScopes?: string[], systemEnvironment?: NodeJS.ProcessEnv): string[];
\ No newline at end of file
+export declare function apiScopes(api: API, extraScopes?: string[]): string[];
\ No newline at end of file

packages/cli-kit/dist/public/node/context/local.d.ts

@@ -26,12 +26,12 @@ export declare function isDevelopment(env?: NodeJS.ProcessEnv): boolean;
  */
 export declare function isVerbose(env?: NodeJS.ProcessEnv): boolean;
 /**
- * It returns true if the App Management API is available.
+ * It returns true if the App Management API is disabled.
+ * This should only be relevant when using a Partners token.
  *
- * @param env - The environment variables from the environment of the current process.
- * @returns True if the App Management API is available.
+ * @returns True if the App Management API is disabled.
  */
-export declare function isAppManagementEnabled(env?: NodeJS.ProcessEnv): boolean;
+export declare function isAppManagementDisabled(): boolean;
 /**
  * Returns true if the environment in which the CLI is running is either
  * a local environment (where dev is present) or a cloud environment (spin).

[amcaplan]

Merge activity

• Jan 16, 12:57 PM EST: A user started a stack merge that includes this pull request via Graphite.
• Jan 16, 12:57 PM EST: A user added this pull request to the GitHub merge queue with Graphite.