Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow for CodeQL Analysis #5332

Merged
merged 4 commits into from
Feb 6, 2025
Merged

Add workflow for CodeQL Analysis #5332

merged 4 commits into from
Feb 6, 2025

Conversation

gonzaloriestra
Copy link
Contributor

@gonzaloriestra gonzaloriestra commented Jan 31, 2025

WHY are these changes introduced?

The default CodeQL setup is not working since April because of a wrong configuration, but it doesn't show any error.

cli 2025-02-05 12-52-36

I tried to add the Security Code Scanner tool by Shopify in #5333, but it looks like it's failing because it's not ready yet for public repos.

So I'm adding a custom CodeQL workflow, generated from GitHub with the default values. It seems to work.

WHAT is this pull request doing?

  • Removes the Security Code Scanner workflow that doesn't work
  • Adds a CodeQL workflow

How to test your changes?

CI

Measuring impact

How do we know this change was effective? Please choose one:

  • n/a - this doesn't need measurement, e.g. a linting rule or a bug-fix
  • Existing analytics will cater for this addition
  • PR includes analytics changes to measure impact

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes

Copy link
Contributor

github-actions bot commented Jan 31, 2025

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.6% (+0.03% 🔼)
9052/11974
🟡 Branches
70.84% (+0.03% 🔼)
4415/6232
🟡 Functions
75.4% (+0.04% 🔼)
2375/3150
🟡 Lines
76.11% (+0.04% 🔼)
8548/11231
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
95.45% 100%

Test suite run success

2044 tests passing in 913 suites.

Report generated by 🧪jest coverage report action from 2fbc091

@gonzaloriestra
Copy link
Contributor Author

Closing in favor of #5333

@gonzaloriestra gonzaloriestra deleted the codeql-workflow branch February 5, 2025 11:43
@gonzaloriestra gonzaloriestra restored the codeql-workflow branch February 5, 2025 11:46
@gonzaloriestra gonzaloriestra reopened this Feb 5, 2025
@gonzaloriestra gonzaloriestra marked this pull request as ready for review February 6, 2025 10:44
@gonzaloriestra gonzaloriestra requested a review from a team as a code owner February 6, 2025 10:44
Copy link
Contributor

@amcaplan amcaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right, let's see how it runs!

Copy link
Contributor Author

gonzaloriestra commented Feb 6, 2025

Merge activity

  • Feb 6, 6:15 AM EST: A user started a stack merge that includes this pull request via Graphite.
  • Feb 6, 6:15 AM EST: A user added this pull request to the GitHub merge queue with Graphite.

@gonzaloriestra gonzaloriestra added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 5b9b228 Feb 6, 2025
28 checks passed
@gonzaloriestra gonzaloriestra deleted the codeql-workflow branch February 6, 2025 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants