add some LFs and docblocks

Shopify · Jul 18, 2020 · 0e15a2d · 0e15a2d
1 parent c21ddf8
commit 0e15a2d
Show file tree

Hide file tree

Showing 4 changed files with 37 additions and 0 deletions.
diff --git a/src/Draggable/Sensors/MouseSensor/MouseSensor.js b/src/Draggable/Sensors/MouseSensor/MouseSensor.js
@@ -32,6 +32,20 @@ export default class MouseSensor extends Sensor {
      */
     this.mouseDownTimeout = null;
 
+    /**
+     * Save pageX coordinates for delay drag
+     * @property {Numbre} pageX
+     * @private
+     */
+    this.pageX = null;
+
+    /**
+     * Save pageY coordinates for delay drag
+     * @property {Numbre} pageY
+     * @private
+     */
+    this.pageY = null;
+
     this[onContextMenuWhileDragging] = this[onContextMenuWhileDragging].bind(this);
     this[onMouseDown] = this[onMouseDown].bind(this);
     this[onMouseMove] = this[onMouseMove].bind(this);

diff --git a/src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js b/src/Draggable/Sensors/MouseSensor/tests/MouseSensor.test.js
@@ -275,6 +275,7 @@ describe('MouseSensor', () => {
       }
       expect(dragFlow).toHaveTriggeredSensorEvent('drag:start', 1);
     });
+
     it('only triggers `drag:start` sensor event once when distance is met after delay', () => {
       function dragFlow() {
         clickMouse(draggableElement);

diff --git a/src/Draggable/Sensors/TouchSensor/TouchSensor.js b/src/Draggable/Sensors/TouchSensor/TouchSensor.js
@@ -65,6 +65,20 @@ export default class TouchSensor extends Sensor {
      */
     this.touchMoved = false;
 
+    /**
+     * Save pageX coordinates for delay drag
+     * @property {Numbre} pageX
+     * @private
+     */
+    this.pageX = null;
+
+    /**
+     * Save pageY coordinates for delay drag
+     * @property {Numbre} pageY
+     * @private
+     */
+    this.pageY = null;
+
     this[onTouchStart] = this[onTouchStart].bind(this);
     this[onTouchEnd] = this[onTouchEnd].bind(this);
     this[onTouchMove] = this[onTouchMove].bind(this);

diff --git a/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js b/src/Draggable/Sensors/TouchSensor/tests/TouchSensor.test.js
@@ -26,9 +26,12 @@ describe('TouchSensor', () => {
     touchSensor.detach();
     sandbox.parentNode.removeChild(sandbox);
   }
+
   describe('common', () => {
     beforeEach(setup);
+
     afterEach(teardown);
+
     it('cancels `drag:start` event when canceling sensor event', () => {
       sandbox.addEventListener('drag:start', (event) => {
         event.detail.cancel();
@@ -51,6 +54,7 @@ describe('TouchSensor', () => {
 
       expect(dragFlow).not.toHaveTriggeredSensorEvent('drag:start');
     });
+
     it('prevents context menu while dragging', () => {
       touchStart(draggableElement);
       let contextMenuEvent = triggerEvent(draggableElement, 'contextmenu');
@@ -94,12 +98,14 @@ describe('TouchSensor', () => {
       expect(touchEndEvent.defaultPrevented).toBe(true);
     });
   });
+
   describe('using distance', () => {
     beforeEach(() => {
       setup({delay: 0, distance: 1});
     });
 
     afterEach(teardown);
+
     it('does not trigger `drag:start` before distance has been travelled', () => {
       function dragFlow() {
         touchStart(draggableElement);
@@ -153,6 +159,7 @@ describe('TouchSensor', () => {
     beforeEach(() => {
       setup({delay: DRAG_DELAY, distance: 0});
     });
+
     afterEach(teardown);
 
     it('does not trigger `drag:start` before delay ends', () => {
@@ -210,6 +217,7 @@ describe('TouchSensor', () => {
     beforeEach(() => {
       setup({delay: DRAG_DELAY, distance: 1});
     });
+
     afterEach(teardown);
 
     it('does not trigger `drag:start` before delay ends', () => {