Bump MaxClients in WEBrick

Shopify · Oct 10, 2023 · 8159121 · 8159121
1 parent 6d41d77
commit 8159121
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 9 deletions.
diff --git a/test/helpers/ghostferry_helper.rb b/test/helpers/ghostferry_helper.rb
@@ -158,6 +158,7 @@ def start_server
         BindAddress: "127.0.0.1",
         Port: @server_port,
         Logger: @logger,
+        MaxClients: 1024,
         AccessLog: [],
       )
 

diff --git a/test/integration/interrupt_resume_test.rb b/test/integration/interrupt_resume_test.rb
@@ -50,18 +50,10 @@ def test_interrupt_and_resume_without_last_known_schema_cache
   def test_interrupt_resume_with_writes_to_source
     # Start a ghostferry run expecting it to be interrupted.
     datawriter = new_source_datawriter
-    ghostferry = new_ghostferry(MINIMAL_GHOSTFERRY)
+    ghostferry = new_ghostferry_with_interrupt_after_row_copy(MINIMAL_GHOSTFERRY, after_batches_written: 2)
 
     start_datawriter_with_ghostferry(datawriter, ghostferry)
 
-    batches_written = 0
-    ghostferry.on_status(Ghostferry::Status::AFTER_ROW_COPY) do
-      batches_written += 1
-      if batches_written >= 2
-        ghostferry.send_signal("TERM")
-      end
-    end
-
     dumped_state = ghostferry.run_expecting_interrupt
     assert_basic_fields_exist_in_dumped_state(dumped_state)