Skip to content

Commit

Permalink
add a todo comment when reporting errors from copydb to callback
Browse files Browse the repository at this point in the history
  • Loading branch information
Manan007224 committed May 13, 2021
1 parent 3199b9a commit a596933
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions copydb/cmd/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,8 @@ func main() {

err = ferry.Initialize()
if err != nil {
// This is not a good idea to reach deep within ferry from copydb. The entire ErrorHandler needs
// refactoring which is defined in this issue - https://github.com/Shopify/ghostferry/issues/284
ferry.Ferry.ErrorHandler.ReportError("ferry.initialize", err)
errorAndExit(fmt.Sprintf("failed to initialize ferry: %v", err))
}
Expand Down

0 comments on commit a596933

Please sign in to comment.