Extend inline verifier to do deep comparison of json objects #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtaner
force-pushed
the
mt/inline-verifier-to-support-json-float-mismatch
branch
from
4376c22
to
ed9a90b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline verifier checks were failing when binlog streamed event includes a json that contains a float value with trailing 0, e.g.
{"amount": 15.0 }. go-mysql is parsing this with (json unmarshall/marshall) to{"amount": 15 }. As inline verifier is using checksum check for the whole row, this is failing, even though 15.0 & 15 can be considered the same. (this does not apply to values such as15.123, these are all copied correctly.)So as a fix if the checksum check fails, this logic will check for any json column and if they are present, then it will do a deep comparison between json values.
Very new to golang, so welcoming suggestions for improvements or anything I might have missed in the logic.