Reorganise Ruby tests #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
carve out logrus before updating golang please |
driv3r
requested changes
Dec 6, 2024
.gitignore
Outdated
| @@ -17,7 +17,6 @@ bin/ | |||
| .vagrant/ | |||
| build/ | |||
| .bundle/ | |||
| .vscode/ | |||
There was a problem hiding this comment.
why do we remove this from git ignore?
.vscode/launch.json
Outdated
| "program": "rake test TEST=${file}" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
please lets avoid any unnecessary IDE related staff out
There was a problem hiding this comment.
Good point, I added these only before finding out that adding rake might make sense, and now ruby-lsp runs tests just fine. Removing!
grodowski
commented
Dec 6, 2024
| @@ -1,6 +1,6 @@ | |||
| require "test_helper" | |||
|
|
|||
| class TrivialIntegrationTests < GhostferryTestCase | |||
| class TrivialIntegrationTest < GhostferryTestCase | |||
There was a problem hiding this comment.
TIL: ruby-lsp doesn't recognise test classes with plural names
|
Re: |
driv3r
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reorganise to run minitests with
rakeand enable a few neat things:main.rbruby-lspgoodness in Code: run/debug single test and test explorerFWIW I wanted to do the same for golang, but the current Go extension for Code requires
1.19+, so agoupdate may be due in a separate PR. Any objections to do that?