Merge pull request #1833 from Shopify/fast-variable-parse

Faster Variable BlockBody Matching
Shopify · Oct 28, 2024 · b419648 · b419648
2 parents 6d58c41 + fb6ac72
commit b419648
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/lib/liquid/block_body.rb b/lib/liquid/block_body.rb
@@ -246,10 +246,17 @@ def render_node(context, output, node)
     end
 
     def create_variable(token, parse_context)
-      if token =~ ContentOfVariable
-        markup = Regexp.last_match(1)
+      if token.end_with?("}}")
+        i = 2
+        i = 3 if token[i] == "-"
+        parse_end = token.length - 3
+        parse_end -= 1 if token[parse_end] == "-"
+        markup_end = parse_end - i + 1
+        markup = markup_end <= 0 ? "" : token.byteslice(i, markup_end)
+
         return Variable.new(markup, parse_context)
       end
+
       BlockBody.raise_missing_variable_terminator(token, parse_context)
     end