Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BT] Reparent categories under Feeding Essentials #406

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardotejedorsanz
Copy link
Contributor

@ricardotejedorsanz ricardotejedorsanz commented Oct 15, 2024

For consistency, reparenting under Feeding Essentials the following categories and subcategories: Baby Bottle Nipples & Liners, Baby Bottles, Bibs and Sippy Cups.

@chesterbot01 @jeanrick This is the first example of mappings across more than one Shopify legacy version. I would appreciate your reviews to ensure everything is as expected.

image
image

@ricardotejedorsanz
Copy link
Contributor Author

@tylerrowsell since these category names already existed, is there a quick way to bypass the async localization step by reusing existing translations and fit this change into the 2024-10 release before we freeze an RC?

# Shopify Product Taxonomy - Mapping shopify/2024-07 to shopify/2024-10-unstable
# Format:
# → {base taxonomy category name}
# ⇒ {mapped taxonomy category name}
Copy link
Member

@tylerrowsell tylerrowsell Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems off here... there should've been mappings here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines +4 to +17
{
"input_taxonomy": "shopify/2024-10-unstable",
"output_taxonomy": "google/2021-09-21",
"rules": [

]
},
{
"input_taxonomy": "shopify/2022-02",
"output_taxonomy": "shopify/2024-10-unstable",
"rules": [

]
},
Copy link
Member

@tylerrowsell tylerrowsell Oct 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something seems wrong with the generate mappings command. I wouldn't expect other mappings to show in the file specific to 2024-07 -> 2024-10

@chesterbot01

@tylerrowsell
Copy link
Member

is there a quick way to bypass the async localization step by reusing existing translations and fit this change into the 2024-10 release before we freeze an RC?

You could update the values in each locale file in /data

Likely something chat gpt can help you write a script for.

For each file in the `localizations/categories/*.yml directory update the keys that start with bt-10-2 to bt-10-16-5 

@ricardotejedorsanz
Copy link
Contributor Author

You could update the values in each locale file in /data
Likely something chat gpt can help you write a script for.

@tylerrowsell The script works well to replace the old ids with the new ones in /data, but the parent-id bt-10-16 is a new category that only exists in the en locale... which blocks the generation of the .dist files. We might need to postpone to 2025-01, unless I'm missing something?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2025-01 taxonomy-tree-requests Suggestion to improve to the taxonomy tree
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants