Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placeholder image sizing fix #44

Closed
wants to merge 1 commit into from
Closed

Conversation

ludoboludo
Copy link
Contributor

Placeholder sizing should be now applied properly.

When playing with the image block size, it would sometimes overflow the svg outside the bounds of the container div.
This helps with making sure the placeholder is always covering the area properly.

Contains doesn't work on placeholders atm. Seem likes we would need to tweak the preservedAspectRatio attribute on the svg itself but we don't have control over it. So i think it's ok for now to keep it as is.

@ludoboludo ludoboludo requested review from tyleralsbury and kjellr July 3, 2024 16:20
@ludoboludo ludoboludo closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant