Skip to content

Commit

Permalink
Add machine id to telemetry logger properties (#3193)
Browse files Browse the repository at this point in the history
<!--
NOTE: If you plan to invest significant effort into a large pull request with multiple decisions that may impact the long term maintenance of the Ruby LSP, please open a [discussion](https://github.com/Shopify/ruby-lsp/discussions/new/choose) first to align on the direction.
-->

### Motivation

<!-- Closes # -->

<!-- Explain why you are making this change. Include links to issues or describe the problem being solved, not the solution. -->

Adding machine id to our logs will help us debug issues with Ruby LSP and better identify gaps in the development experience we're hoping to create.

### Implementation

<!-- How did you implement your changes? Explain your solution, design decisions, things reviewers should watch out for. -->

Added a new field to our logger.
  • Loading branch information
egiurleo committed Feb 13, 2025
1 parent 72f6641 commit 1347d79
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions vscode/src/extension.ts
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ async function createLogger(context: vscode.ExtensionContext) {
additionalCommonProperties: {
extensionVersion: context.extension.packageJSON.version,
environment: os.platform(),
machineId: vscode.env.machineId,
},
});
}

0 comments on commit 1347d79

Please sign in to comment.