Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Minitest/AssertPredicate cop #1249

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Enable Minitest/AssertPredicate cop #1249

merged 1 commit into from
Dec 13, 2023

Conversation

andyw8
Copy link
Contributor

@andyw8 andyw8 commented Dec 13, 2023

@andyw8 andyw8 requested a review from a team as a code owner December 13, 2023 15:10
@andyw8 andyw8 requested review from st0012 and vinistock December 13, 2023 15:10
@andyw8 andyw8 mentioned this pull request Dec 13, 2023
Merged
vinistock
vinistock approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@vinistock vinistock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why this isn't enabled by default. Is this something we can configure in rubocop-shopify too?

@andyw8 andyw8 merged commit de6df42 into main Dec 13, 2023
24 of 30 checks passed
@andyw8 andyw8 deleted the andyw8/enable-minitest-assert-predicate branch December 13, 2023 17:22
@andyw8
Copy link
Contributor Author

andyw8 commented Dec 13, 2023

It's from rubocop-minitest rather than rubocop, so we don't have a standard config for that.

@andyw8
Copy link
Contributor Author

andyw8 commented Dec 13, 2023

But there is some exploration for other plugin configs: Shopify/ruby-style-guide#498

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinistock vinistock vinistock approved these changes

@st0012 st0012 Awaiting requested review from st0012 st0012 was automatically assigned from Shopify/ruby-dev-exp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andyw8 @vinistock