Resolve test items with server request #3186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 12, 2025
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
vinistock
added
enhancement
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
2c157b1 to
90dcc46
Compare
andyw8
reviewed
Feb 12, 2025
vinistock
force-pushed
the
01-31-add_discover_tests_custom_request
branch
from
7676523 to
1170bf3
Compare
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
90dcc46 to
f655e87
Compare
vinistock
force-pushed
the
01-31-add_discover_tests_custom_request
branch
from
1170bf3 to
4760446
Compare
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
f655e87 to
a9c25ec
Compare
andyw8
approved these changes
Feb 12, 2025
vinistock
force-pushed
the
01-31-add_discover_tests_custom_request
branch
from
4760446 to
8f68f57
Compare
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
a9c25ec to
df362b5
Compare
st0012
reviewed
Feb 12, 2025
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
df362b5 to
02f1612
Compare
vinistock
force-pushed
the
01-31-add_discover_tests_custom_request
branch
2 times, most recently
from
8dcf69e to
f4582ce
Compare
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
02f1612 to
1743447
Compare
vinistock
force-pushed
the
01-31-add_discover_tests_custom_request
branch
from
f4582ce to
dcd90c6
Compare
vinistock
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
2 times, most recently
from
44e772a to
d7d005f
Compare
vinistock
force-pushed
the
01-31-add_discover_tests_custom_request
branch
from
dcd90c6 to
4e5dceb
Compare
st0012
approved these changes
Feb 13, 2025
Merge activity
|
### Motivation Closes #3171 Add a new custom request to discover tests in a specific document. This request will instantiate all listeners and collect all of the discovered groups and examples as test items for the editor. ### Implementation - Created the new request - Implement a listener dedicated to the test style syntax only (spec will be a separate listener) - Ensured to use ancestor linearization to determine the test framework ### Automated Tests Added tests.
### Motivation Closes #3173 Start firing our new custom request to discover which tests are available in a given file. ### Implementation We fire the request and then recursively add test items to their respective collections. If a document is saved, we check to see if we created a test item for it and then we clear its children (the tests defined inside of the file) and re-trigger the request. I chose to use on save because on change would put a lot of pressure on the server. ### Automated Tests Added tests.
graphite-app
bot
force-pushed
the
01-31-add_discover_tests_custom_request
branch
from
4e5dceb to
7d66850
Compare
graphite-app
bot
force-pushed
the
02-11-resolve_test_items_with_server_request
branch
from
d7d005f to
fdaf468
Compare
Base automatically changed from
01-31-add_discover_tests_custom_request
to
main
February 13, 2025 20:00
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Closes #3173
Start firing our new custom request to discover which tests are available in a given file.
Implementation
We fire the request and then recursively add test items to their respective collections. If a document is saved, we check to see if we created a test item for it and then we clear its children (the tests defined inside of the file) and re-trigger the request.
I chose to use on save because on change would put a lot of pressure on the server.
Automated Tests
Added tests.