Use Prism parser engine #621
Conversation
Once Prism support is stable in RuboCop, we'll likely want to default to enabling it.
github-actions
bot
added
the
config change
| @@ -23,5 +23,6 @@ Gem::Specification.new do |s| | |||
|
|
|||
| s.required_ruby_version = ">= 2.7.0" | |||
|
|
|||
| s.add_dependency("rubocop", "~> 1.51") | |||
| s.add_dependency("prism") | |||
There was a problem hiding this comment.
I think in the final form, we would want a lower bound on the version of Prism, to make sure that we have all the bugfixes related to RuboCop translation layer in.
There was a problem hiding this comment.
Yeah, agreed. I was a little surprised rubocop-ast doesn't require a minimum version. It seems like something you'd want to do if you know it won't work with versions below some minimum.
There was a problem hiding this comment.
Yeah, agreed. I think once we are past v1.0 of Prism, then we should be able to add that as a minimum version. otherwise, my concern is that folks who try RuboCop with Prism as a backend on vanilla Ruby 3.3 will have a bad time, since the version of Prism released with Ruby 3.3 will be horribly out of date.
There was a problem hiding this comment.
Yeah, agreed. RuboCop's bug report template asks the submitted to include the output of rubocop -V which would include the Prism version, but I don't understand why not simply restrict the version and prevent bug reports against outdated Prism versions from being opened in the first place.
Once Prism support is stable in RuboCop, we'll likely want to default to enabling it.
As of https://github.com/rubocop/rubocop/releases/tag/v1.62.0, support is experimental, so we don't want to merge this yet.