Merge pull request #508 from Shopify/shanempope-patch-1

Create a more efficient regex
Shopify · Oct 26, 2023 · ad1515c · ad1515c
2 parents 7f19857 + 37c01ec
commit ad1515c
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/lib/semian/activerecord_trilogy_adapter.rb b/lib/semian/activerecord_trilogy_adapter.rb
@@ -91,11 +91,7 @@ def resource_exceptions
     end
 
     # TODO: share this with Mysql2
-    QUERY_ALLOWLIST = Regexp.union(
-      %r{\A(?:/\*.*?\*/)?\s*ROLLBACK}i,
-      %r{\A(?:/\*.*?\*/)?\s*COMMIT}i,
-      %r{\A(?:/\*.*?\*/)?\s*RELEASE\s+SAVEPOINT}i,
-    )
+    QUERY_ALLOWLIST = %r{\A(?:/\*.*?\*/)?\s*(ROLLBACK|COMMIT|RELEASE\s+SAVEPOINT)}i
 
     def query_allowlisted?(sql, *)
       QUERY_ALLOWLIST.match?(sql)